Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable10] install order #29267

Merged
merged 2 commits into from
Oct 23, 2017
Merged

[stable10] install order #29267

merged 2 commits into from
Oct 23, 2017

Conversation

tomneedham
Copy link
Contributor

Backport of #29142 to stable10.

Tested that the install works locally for me with my reset script

@tomneedham tomneedham added this to the development milestone Oct 17, 2017
@tomneedham tomneedham self-assigned this Oct 17, 2017
PVince81
PVince81 approved these changes Oct 17, 2017
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Oct 17, 2017 •
edited
Loading

Codecov Report

Merging #29267 into stable10 will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #29267      +/-   ##
==============================================
- Coverage        58.4%   58.38%   -0.02%     
- Complexity      17693    17696       +3     
==============================================
  Files            1059     1059              
  Lines           59341    59358      +17     
==============================================
  Hits            34657    34657              
- Misses          24684    24701      +17
Impacted Files Coverage Δ Complexity Δ
lib/private/Setup.php 16.5% <ø> (ø) 49 <0> (ø) ⬇️
lib/private/Installer.php 46.83% <0%> (-3.62%) 93 <16> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef290c2...bc3104a. Read the comment docs.

@PVince81
Copy link
Contributor

Please rebase to trigger Jenkins build

@phil-davis phil-davis changed the title Stable10 install order [stable10] install order Oct 20, 2017
@PVince81 PVince81 merged commit 694f4ca into stable10 Oct 23, 2017
@PVince81 PVince81 deleted the stable10-install-order branch October 23, 2017 12:12
@SergioBertolinSG SergioBertolinSG mentioned this pull request Nov 28, 2017
Closed
87 tasks
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees

@tomneedham tomneedham

Labels
4 - To release status/STALE
Projects
None yet
Milestone
10.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@tomneedham @PVince81 @ownclouders